Design/Meetings/2014-02-16

Attendees

 * mirek
 * astron

Topics
Tango Testing icons

Log
[12:18] hi astron [12:18] hi there [12:18] any topics you'd like to discuss? [12:19] we could go through the options dialog again, if you'd like [12:19] how is your patch with all the icons? [12:21] (or rather, did you see you were asked to make some changes?) [12:21] about icons: [12:21] I originally just wanted to push the print icons [12:22] then I noticed Alex pushed some of the Tango testing icons [12:22] a lot of them... [12:22] if not even all of them. [12:23] so I looked at what icons he pushed and replaced them with the more recent Tango testing equivalents [12:23] and added new ones where there weren't any [12:23] (Alex's patch didn't include small versions of icons) [12:23] ok. so far, so good. [12:24] that patch was rejected because of a merge problem [12:24] no, you just need to change it a little to account for a renaming [12:24] meanwhile, I noticed that Ahmad started copying over icon sheets from Tango testing [12:24] ok... [12:24] astron: yes, that's what I meant [12:25] where does ahmad copy them? [12:25] (or rather from where to where?) [12:25] I wasn't overly happy with the new icons anyway, so I held off on modifying the patch, hoping to change the icons a bit more before committing [12:25] astron: to the flat icon repository [12:26] oh, so ahmad is trying to order sifr like tango testing [12:26] the plan is to share sheets for making the icons [12:26] i see [12:26] makes things easier [12:26] the problem is that not all icons are categorized yet [12:26] so I've been spending some time lately trying to categorize the rest of the icons [12:27] ok, since your icons (just imo) are quite a bit better than alex's (and also because there are small versions of them), could you still try to update the patch? [12:27] btw, any idea on where in LibreOffice I might see the sfx2/res icons? [12:28] astron: I want to make a few changes first, if that's ok [12:29] i dont think it hurts to iterate in master, seriously. [12:29] the sfx2/res icons are a bit of a mixed bag, but you might see some in the help browser, possibly... [12:30] how do I get to the help browser? [12:30] what kind of libreoffice build are you in right now? [12:31] one of the latest ones [12:31] my stable version is 4.2.0.2 [12:32] ok, use stable, & press F1 [12:32] if you dont end up in a web browser, thats it [12:32] unfortunately, I do end up in a browser [12:32] if you do end up in a web browser, you still need to install the help package [12:33] synaptic or so, search for libreoffice-help-{language code} [12:34] thanks for that :) [12:36] some of the other icons may turn up when signing/encrypting documents [12:36] you mean the 128x128 ones? [12:37] styfam3 is kind of a mystery to me, btw -- is it supposed to be line styles? [12:37] i have no idea. [12:38] also, i would suppose that sortascending e.g. appears in the template manager [12:39] hm... the other template manager icons are all in sfx2/imglist [12:39] odd [12:39] :) [12:39] sortascending is easy to take care of, though -- I just link it with all the other cmd/lc_sortascending.png [12:42] I'm just a bit cautious about linking styfam1, styfam2, and styfam4 to what appears to be character, paragraph, and page styles [12:42] and newex.png I have no clude about [12:42] -d [12:44] other problematic areas, if you have any clue about them: [12:44] newex -- new style..? [12:44] extensions/res icons [12:45] thats messy [12:45] the icon theme includes icons for an extension [12:45] actually, extensions folder in general [12:45] (its probably pre-installed, but not sure.) [12:46] astron: I suppose so [12:46] scanner is for Insert > Image > Scan in writer (not sure exactly what the option is called), i think. but i dont think they are in use. [12:46] not sure. [12:47] ok, I'll look at that [12:47] well, maybe my assumption there is wrong. [12:47] reportdesign? [12:47] try to git grep for the image names maybe [12:48] reportdesign -- there is a report generator for base (pre-installed extension) [12:48] I'm guessing that's the report builder, just need to look at it [12:48] I use opengrok -- https://opengrok.libreoffice.org/ [12:48] should be basically the same [12:49] extensions/source/update/ui/ icons afaik are only shown on windows/mac when an update is available [12:49] not always helpful, though [12:49] mirek2: git grep works when there is no internet too [12:49] but yeah.. [12:49] :) not a problem I tend to have [12:50] astron: I'm basing categorization on the packaged icon files [12:50] there's no update/ui folder there, probably because I'm building on Linux [12:50] so, fdo's icon naming spec is not working for you? [12:51] i am looking at it in the libo core repository [12:51] by "basing categorization", I meant that I don't look at the icon folders, but at the packaged icon files [12:51] are you looking through the zip files? [12:52] I unpacked and merged the zip files and am categorizing based on them, yes [12:52] mirek2: not sure what to make of what you said [12:53] :) to get a list of icons to categorize, I: [12:54] a) unpacked the zip files in instdir/share/config [12:54] b) merged them [12:54] I'm categorizing only icons from that [12:55] is that clearer? [12:55] ok. [12:55] thanks [12:55] (btw, I started out categorizing e.g. the cmd folder from the folder hierarchy, not from the zip files, so there might be some extra icons there) [12:55] but why are you not starting from the repository? [12:55] (where most of the unused icons should have been cleared out already) [12:56] I didn't want to rely on the unused icons being cleared out already [12:56] (are you sure they've been cleared out from each of the sets?) [12:57] the way youre doing it, you will have problems if icons are used on only one os [12:57] yes [12:57] on the other hand, do we really have that many of those? [12:57] not sure how many there are [13:00] honestly, I just wanted to avoid categorizing boatloads of forgotten icons [13:00] hopefully the Os [13:00] this situation has vastly improved in the past years [13:00] ... the OS-specific ones will find their way into sheets [13:01] ok [13:01] astron: even in the galaxy and industrial folders? [13:02] not completely sure about industrial or human, but galaxy should be clean [13:03] (btw, any idea why sfx2/res/symphony/sidebar-colors-large.png exists? or sidebar-eyedropper-large.png? or sidebar-3d-large.png? were those cut features?) [13:04] not sure. maybe those are features still to come? [13:05] possibly... [13:06] any clue what svx/res/fw01.png to fw021.png are for, and why they're black and white? [13:07] i would try to look for them in draw. [13:07] but no, not really [13:08] (have i any idea what they are good for) [13:09] wait ... someone has replaced my markers sheet in galaxy... [13:09] probably with the old one from aoo [13:11] (sudden disconnection, sorry) [13:11] its fine [13:11] perhaps it's better to keep the markers different for the galaxy theme? [13:12] they were different [13:12] oh, ok [13:12] you designed special markers for galaxy? [13:12] same shapes, but different colors [13:13] ok, makes sense [13:14] also, I can't find svx/res/galsnd*.png anywhere in LibreOffice [13:14] not sure what markers2 is good for. [13:14] I assume they were used for sounds [13:15] yes. they were used in the gallery as visualisations of sounds [13:15] not sure what the color coding in galdef, galnor, and galrdo represent [13:15] different types of gallery folders. [13:15] yes, but what differentiates the type [13:16] all of that is afaik not really in use but i think it leads to build failures when you remove it without changing the source [13:17] galdef, galnor, and galrdo are in use in the galaxy theme [13:17] oh ... so [13:17] I now think it represents whether it's the user's [13:17] or whether it's bundled [13:18] the icons are linked to a folder icon in the Tango theme [13:18] yes [13:18] I don't think the sound icons are used [13:18] not sure whether to include them in the icon sheets... [13:18] I'm leaning towards no [13:19] they are not used. [13:19] as i said, you cant remove them without build errors [13:19] (i think i tried) [13:19] not sure [13:19] ok, I won't include them then [13:20] icons from wizards/res -- do you know where they're used? [13:21] nevermind, I see that they're used in the web wizard [13:22] (at least some of them) [13:22] yes [13:22] there are other wizards too :) [13:23] not sure they need to be adorned with this stuff [13:23] yes, but I don't think any others use the icons [13:24] what stuff? the web wizard icons are pretty key in the web wizard [13:24] oh i hadnt looked into the folders, i thought you were referring to the header images [13:25] sorry. [13:25] that's ok [13:25] not sure the header images are still around [13:25] you mean e.g. the presentation header images? [13:26] yes, they're still there [13:26] presentation wizard [13:26] ok [13:27] do you want to look at options again? [13:28] or should we call it a day? [13:28] or any other topics you'd like to cover? [13:28] well, id have simple question before: [13:29] are you okay if the Close Find Bar icon is lc_closedoc instead of lc_cancel? [13:29] (i would create a patch changing the links file for that) [13:29] actually, that was one of the changes to links.txt that I was going to push :) [13:29] oh... then [13:30] do you mind if i do that separately? [13:30] (i also removed sc_exitsearch which is clearly a galaxy icon) [13:33] (btw, there are a lot of changes coming with the links.txt file I plan to push -- e.g. the sidebar icons will change to the Tango ones, the Navigator icons as well, ...) [13:33] cool. [13:33] the new properties icon will be a wrench [13:34] ok... wrenches make us all happy. [13:34] :) just be prepared to see a lot more wrenches coming [13:36] 4.3 is still some time away. if, g*d forbid, anyone were unhappy with them, we could still change them [13:37] any other questions/concerns? [13:37] hm we should talk about the copy-styles-from-other-templates thing... but i was too lame to even look at it in the past two weeks [13:38] so, i will let that debut on the ml [13:38] ok, sure [13:39] oh... then on the topic of options: [13:40] so, i realised how little sense the "unnecessary" category makes -- nobody will actually completely remove any option. [13:40] (or at least it is unlikely unless it consistently leads to crashes or so) [13:40] (and is unimportant) [13:40] right -- completely agree [13:41] would just use the "advanced" label for unnecessary [13:42] well, we should do that for most things. but some, like the memory options are actually unnecessary, because they should depend on the computers capabilities and don't need to be saved anywhere, i would think [13:42] (or maybe they should still be cached?) [13:42] well, not according to the conversation we had at the hackfest [13:42] I'm honestly not bothered by that staying in advanced options [13:42] ok [13:43] then just move everything => advanced [13:43] i would say [13:44] all the unnecessary ones, yes :) [13:44] yes. sorry for the overly broad statement [13:45] btw, on a completely unrelated note, if you want to get a feel for how the new iwork works, there's a series of videos on YouTube: https://www.youtube.com/watch?v=39uMYUq_p1U [13:45] interesting to see that the style picker has the same split buttons as the Google Docs one [13:46] ok [13:48] also, their sidebar is linked to toolbar buttons, which is what I have been pushing for [13:49] ok. [13:49] im watching it now... i guess we can close the chat... [13:49] should i upload the log? [13:50] yes, go ahead [13:51] bye [13:51] bye