Talk:Documentation/Calc Functions/ADDRESS

SF Comments
Note: There are a lot of changes here. Please sanity-check my suggestions!
 * (1) Summary. Suggest removing some of the material that is really about arguments. Suggest the following replacement text – “Constructs a cell reference as a text string, for specified row and column numbers.”.
 * (2) Returns. Suggest the following replacement text – “Returns a cell reference as a text string, for the given arguments.”.
 * (3) Arguments, Row. Delete “non-negative” - Row can be negative for some R1C1 options. Also, delete the redundant “(the number, not the letter)”.
 * (4) Arguments, Column. Delete “non-negative” - Column can be negative for some R1C1 options. Also, delete the redundant “(the number, not the letter)”.
 * (5) Arguments, Abs. Change “a integer” to “an integer”. Maybe add “as defined in the table below” or something similar.
 * (6) Arguments, table. This table seems misplaced to me because it includes two columns that relate to the A1 argument. Suggest moving table downwards to be after the text describing A1.
 * (7) Arguments, paragraph beginning “If omitted”. Delete – this is covered by the table.
 * (8) Arguments, A1. This should start with something like “A1 is an integer value or a reference to the cell containing that value which determines the type of notation used.” Also, suggest changing existing 2nd sentence to “If this parameter is omitted or set to any value other than 0 or FALSE, the A1 notation is used”.
 * (9) Arguments, Sheet. Replace with something like “Sheet is a text string (in double quotation marks) or a reference to the cell containing that text string which specifies the name of a sheet to be appended at the front of the cell reference. Calc does not check that a sheet of this name currently exists within the spreadsheet.”
 * (10) Arguments, 1st bullet. I do not believe that A1 is truncated, it is either 0/FALSE or it is not. Suggest replacing with the following – “If any of Row, Column or Abs are non-integer real numbers, then they are truncated to integer values.”.
 * (11) Arguments, 2nd bullet. Not accurate as currently written. If R1C1 notation is selected (A1 is 0 or FALSE) and the type of reference is selected as row relative or fully relative (Abs is 3 or 4), then after truncation Row must be in the range [-1048575, 1048575]. Otherwise, Row must be in the range [1, 1048576]. An error may also be returned for apparently in-range values that would result in a row that does not exist in the sheet.
 * (12) Arguments, 3rd bullet. Not accurate as currently written. If R1C1 notation is selected (A1 is 0 or FALSE) and the type of reference is selected as column relative or fully relative (Abs is 2 or 4), then after truncation Column must be in the range [-1023, 1023]. Otherwise, Column must be in the range [1, 1024]. An error may also be returned for apparently in-range values that would result in a column that does not exist in the sheet.
 * (13) Arguments, 4th bullet. Can we shed any light on why Abs goes from 1 to 8, while only four values are identified in the table? (It appears to be intentional in the code, but it is note obvious why; also, it appears to be inconsistent with Excel)
 * (14) Arguments, 5th bullet. Change “either” to “any”.
 * (15) Additional details, general. This ought to include descriptions of the A1 and R1C1 notations.
 * (16) Additional details, general. Instead of assorted mentions of the INDIRECT function, it would be a good idea to provide a coherent statement of any relationships between the ADDRESS and INDIRECT functions. I would include the material in the second and third sentences of the description for the 1st example – better not to bury it in the example!
 * (17) Additional details, 1st bullet. I am not sure that this paragraph has any value and recommend deleting it. (As the argument is in ODF 1.2, we do not need to justify including it)
 * (18) Additional details, 2nd bullet. I am not sure that this paragraph has any value and recommend deleting it. (Obvious from syntax and argument descriptions)
 * (19) Additional details, 3rd bullet. I am not sure that this paragraph has any value and recommend deleting it. (Not relevant on this page)
 * (20) Additional details, 4th bullet. I am not sure that this paragraph has any value and recommend deleting it. (Obvious from syntax and argument descriptions)
 * (21) Additional details, 5th bullet. Useful information – include as part of the coherent statement of any relationships between the ADDRESS and INDIRECT functions (mentioned in a previous comment).
 * (22) Additional details, 6th bullet. For better grammar and consistency, suggest rewriting as follows – “When opening documents from ODF 1.0/1.1 format, ADDRESS function calls that have a sheet name as the fourth argument will have that sheet name shifted to become the fifth argument. A new fourth argument with the value 1 will be inserted.”
 * (23) Additional details, 7th bullet. For better grammar and consistency, suggest rewriting as follows – “When saving a document in ODF 1.0/1.1 format, ADDRESS function calls will have their fourth argument removed. In this way, any function calls that previously used R1C1 notation will revert back to A1 notation.”
 * (24) Additional details, 1st Note pin. Is this necessary – it simply repeats what is said in the previous bullet point?
 * (25) Additional details, 2nd Note pin. I am not sure that this is relevant on this page and recommend deleting it.
 * (26) Examples, general. With our improved understanding of this function, as reflected in the above comments, please review whether any extra examples would help.
 * (27) Examples, all. Change “worksheet” to “sheet” (multiple occurrences).
 * (28) Examples, 1st example. Change “Th” to “The”. 2nd sentence – presumably, the intention is to put the value -6 into cell C5 of Sheet3 (not sheet 2). Also need to be clearer about where to put the formula =ABS(INDIRECT(B2)).
 * (29) Examples, 2nd example. Change “Th” to “The”. Change “reference addressing” to “addressing reference”?
 * (30) Examples, 3rd example. Change “reference addressing” to “addressing reference”?
 * (31) Examples, 4th example. Insert “reference” after “addressing” and “the” before “current”.
 * (32) ODF standard. May be worth noting that Calc does not follow some of the constraints given in ODF 1.2.

--Stevefanning (talk) 2020-12-04T10:32:07 (UTC)