From The Document Foundation Wiki
    This page is a translated version of the page Development/gerrit/PatchReview and the translation is 52% complete.
    Outdated translations are marked like this.

    After you completed the gerrit setup, and you or others have submitted patches, you can start to review patches on gerrit.

    Finding patches waiting for review

    ./logerrit query status:open

    will show you all patches waiting for review. see gerrit documentation for all the fancy things you can do in addition (for scripting etc.).

    Getting a patch

    ./logerrit cherry-pick CHANGEID

    with CHANGEID being the Change-Id shown by the output of the gerrit query

    Updating patch

    If you found and fixed a problem during review. You might update the existing patch in gerrit the following way:

    git status; git diff

    which makes sure that you have only the single cherry-picked commit and the extra changes on top

    git commit -a --amend

    which updates the last commit locally

    ./logerrit submit

    which pushes all uncommited changes into gerrit; it updates the existing patch in gerrit if the ID stayed the same in the commit message

    Comment and Approve

    If you want to add comments or approve the patch, the best way is to do it from the Gerrit web interface. Comment by clicking a line of a changed file and when you are done click the Reply... link to publish your review.

    Alternatively, you might just push the patch but it will not add the nice comments about reviewing.

    Code-ReviewVerified について


    • Code-Review
    • Verified



    −2, −1, 0, +1, +2が割り当てられます




    0 はコメントをつける時に使用し、パッチのマージの可否に影響しません。

    +1 は査読者が使用し、パッチはOKだが、査読者に代替案があることを示します。

    +2 は作者が使用し、査読不要であることを示します(これはコアな開発者のみが行うことができ、また注意深く使用されるべきです)。 あなたのパッチをマージする人は、マージ前に+2を使用するでしょう。+2のみがマージ可能であるためです。+2に設定できるかどうかは査読者のpush権限に依存します。この権限は個人個人に与えられます。



    −1、0、+1 が割り当てられます





    +1 は査読者が使用し、期待された結果が再現できたことを示します。


    Note pin.svg

    For more information on those labels, see the gerrit documentation. For gerrit configuration relevant to our projects, see Access Control Lists for all dev-related repositories, for core, and for all other projects.