Talk:Documentation/Calc Functions/DISC

SF Comments

(1) Summary. Suggest replacing with “Calculates the discount rate of a security.”.

(2) Returns. Are we 100% certain that there cannot be a negative discount rate? There is certainly nothing in the code that forces Price to be <= Redemption. Also, add “for the given arguments”.

(3) Arguments, Settlement. Suggest changing “the date at which the interest accrued up until then is to be calculated” to simply “the settlement (purchase) date of the security”.

(4) Arguments, Maturity. Suggest changing “the date on which the security matures (expires)” to “the maturity (redemption) date of the security”.

(5) Arguments, Price. Delete “per 100 currency units of par value” (which may have been originally inherited from the Excel page). What really matters is that Price and Redemption have the same units.

(6) Arguments, Redemption. Delete “per 100 currency units of par value” (which may have been originally inherited from the Excel page). What really matters is that Price and Redemption have the same units.

(7) Arguments, Basis. Please update to address comments on other instances of this argument.

(8) Arguments, 2nd bullet. Change “an” to “a”. Insert space before open bracket.

(9) Arguments, 3rd bullet. Insert “the” before “Settlement”. Update text to reflect that an error will occur if Settlement = Maturity.

(10) Arguments, 5th bullet. Change “ny” to “any”. I would remove the text in brackets as it does not really add anything.

(11) Examples, 1st and 2nd examples. I do not recall using the term “daily balance interest calculation” in all the previously reviewed financial functions. Perhaps we should use “day count convention”, which seems to be a commonly used term. Also, change “how high is the settlement (discount)” to “discount rate”. Suggest put the (rounded) % value (i.e. 3.72%) in brackets after the returned value.

(12) Examples, 4th example. Insert “the” before “Settlement”.

--Stevefanning (talk) 2020-11-16T11:17:16 (UTC)