Talk:Documentation/Calc Functions/LCM EXCEL2003

From The Document Foundation Wiki
Jump to navigation Jump to search

SF Review Comments

(1) Syntax. Please replace with syntax in Help.
(2) General comment. I think some more research may be need on this function. Do we understand why the arguments to this function are Numbers, while the arguments to LCM are Integers? Why is there nothing in this function’s description that limits the function to processing integer values? And what is meant by “get results based on international standards”?

--Stevefanning (talk) 2020-09-14T09:27:08 (UTC)

Ronnie

  • Firstly even though LCM is suppose to take integer argument, it will give return non-error result for non-integer but the output is in integer form but if we consider non-integer input for LCM_EXCEL2003, it will return integer by taking the integer part of input numbers or truncating them. This is what results I found on checking with CalC which I believe pretty much summarizes the query.
  • Syntax changed

--RonnieGandhi

Standard

Hey, any _Excel2003 or _ADD function names are not part of any standard! Dennis Roczek (talk) 2020-09-16T13:01:52 (UTC)

Ronnie

True this function like GCD_EXCEL2003 is not in ODF standard it was left there by mistake thanks for pointing it out, since we are following similar structure Universally, I have added "None" for this section.

--RonnieGandhi 2020-09-16T13:07:55 (UTC)

Just a general "suggestion": why naming the headline "ODF standard" instead of simply Standard?
Many functions can be part of multiple standards (odf, ooxml, mathml, maybe some other stuff, etc.). This might not be relevant for the actual documentation sprint, but maybe for the next. ;-)
Dennis Roczek (talk) 2020-09-17T22:38:24 (UTC)

Olivier

@Dennis: We state ODF Formula standard because we know for sure the function belongs to ODF Formula standard v1.2. If the function is also on another standard, that is beyond the scope the work.